Re: [Linux-fbdev-devel] Re: [PATCH] fbgen & multiple RGBA

[Romain Dolbeau]

James Simmons wrote:
> 
> > the attached patch fix a problem with fbgen when changing the
> > RGBA components but not the depth ; fbgen would not change
> > the colormap in this case, where it should.
> 
> It would be much easier to use a memcmp.

For the color component, yes, but you can't use a memcmp
on the 'fb_var_screeninfo', as some member of the struct
are irrelevant to colormap switching (you don't want
to reinstall the colormap if only the refresh rate changed,
for instance).

-- 
DOLBEAU Romain               | l'histoire est entierement vraie, puisque
ENS Cachan / Ker Lann        |     je l'ai imaginee d'un bout a l'autre
[e-mail]             |           -- Boris Vian