Re: AMD756 PCI IRQ Routing Patch 0.2.0

Jeff Garzik (jgarzik@mandrakesoft.com)
Fri, 22 Jun 2001 14:28:30 -0400

"Jhon H. Caicedo O." wrote:
> This is an updated version of the patch for AMD756 PCI IRQ Routing,
> the changes are to use the read/write_config_nybble functions,
> this makes the code shorter.

Looks much better, thanks!

> + printk(KERN_INFO "AMD756: dev %04x:%04x, router pirq : %d get irq : %2d\n",
> + dev->vendor, dev->device, pirq, irq);
[...]
> + printk(KERN_INFO "AMD756: dev %04x:%04x, router pirq : %d SET irq : %2d\n",
> + dev->vendor, dev->device, pirq, irq);

None of the other PCI IRQ routines print out IRQ routing messages, so
these shouldn't either. I assume this is debugging code?

Further, the printks are potentially misleading, because pirq_amd756_get
might not receive a valid irq, if 'pirq' is greater than 4.

Jeff

-- 
Jeff Garzik      | Andre the Giant has a posse.
Building 1024    |
MandrakeSoft     |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/