Re: [PATCH] remove null register_disk

[Alexander Viro]

On Wed, 20 Jun 2001 [e-mail] wrote:

> In fs/partitions/check.c we read
> 
> void register_disk(struct gendisk *gdev, kdev_t dev, unsigned minors,
>         struct block_device_operations *ops, long size)
> {
>         if (!gdev)
>                 return;
>         grok_partitions(gdev, MINOR(dev)>>gdev->minor_shift, minors, size);
> }
> 
> showing that register_disk is void when its first argument is NULL.
> This allows one to remove some dead code.
> Can be applied to 2.4. No behaviour is changed.

That's simply wrong. We will need register_disk(). Reinserting it into the
right places in 2.5 is a unnecessary PITA.