Re: [PATCH] fix warning in tdfxfb.c

Steven Walter (srwalter@yahoo.com)
Sat, 16 Jun 2001 15:10:14 -0500


On Sat, Jun 16, 2001 at 02:59:34PM -0500, Josh Myer wrote:
> It might be better to add a default case to the switch statement below, so
> this symbol doesn't just eat up another 4(8 on some platforms, and i'm
> sure others) bytes of memory unneccesarily.

I'm not quite sure I follow you. The default case should never be
reached, because only the three cases currently present are allowed by
the encapsulating 'if' statement. Even so, how would adding a default
case get rid of the variable or save space some other way?

> anyway, it doesn't really matter. i'd test my hypothesis, but i've got
> people coming over this afternoon =) the driver looks like it might use
> some scrubbing anyway (s!//(.*)$!/\* $1 \*/!...)

Good point. Perhaps I'll prepare a larger patch with this and other
cleanups.

-- 
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
			-- George Orwell
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/