Re: Minor "cleanup" patches for 2.4.5-ac kernels

[Jeff Garzik]

Michal Jaegermann wrote:
> 
> On Tue, Jun 12, 2001 at 09:03:23PM -0400, Jeff Garzik wrote:
> > Michal Jaegermann wrote:
> > > --- linux-2.4.5ac/drivers/pci/quirks.c~ Tue Jun 12 16:31:12 2001
> > > +++ linux-2.4.5ac/drivers/pci/quirks.c  Tue Jun 12 17:13:18 2001
> > > @@ -18,6 +18,7 @@
> > >  #include <linux/pci.h>
> > >  #include <linux/init.h>
> > >  #include <linux/delay.h>
> > > +#include <linux/sched.h>
> > >
> > >  #undef DEBUG
> > >
> > > There is no problem if SMP is not configured.
> >
> > no the better place for this is include/asm-i386/delay.h.
> 
> You mean to put "#include <linux/sched.h>" into include/linux/delay.h?
> Otherwise this will not help very much on Alpha when I run into
> the problem; or other architectures. :-)  Works for me and indeed
> it may be a better place.

This is an architecture-level thing.  include/asm-$arch/delay not
include/linux/delay.h

Currently, Alpha does not need to include sched.h at all...

> > Then Andrea suggested to
> > simply un-inline udelay, which solved the compile problem in an even
> > better way.  (we cannot un-inline udelay on x86 I think)
> 
> How about other architectures?  Each will need an individual treatment?

Each arch will need individual treatment, but each alpha should decide
for itself whether or not to un-inline udelay.  It may not be possible
on some archs.

-- 
Jeff Garzik      | Andre the Giant has a posse.
Building 1024    |
MandrakeSoft     |