Re: bug in /net/core/dev.c

[Keith Owens]

On Tue, 12 Jun 2001 18:43:41 +0200, 
[e-mail] wrote:
>Hi Keith,
>This is a cure the syntom not the problem, build order shouldn't mess up
>something this simple.

I totally agree on one point.  Having the automatic initialisers in the
same source as the related code is a good idea, it is far better than
the old Space.c method.  Automatically executing the initialisers in
the order they are linked into vmlinux is also a good idea, you must
have some automatic order or you are back to the horrors of Space.c.
But controlling the link order of the initialisers as a side effect of
Makefile compile order sucks big rocks, especially when you have some
Makefiles executing other Makefiles which are not their children.

Link order should be independent of Makefile compile order and it
should be explicitly specified, instead of occurring as a little known
side effect of the convoluted and twisted way that the Makefile tree is
processed.  Alas Linus likes it this way :(.  At least with my 2.5
Makefile rewrite[*] it is more obvious what is going on.  I abhore the
line order dependencies and controling link order at the level of
entire directories when it should be at the level of individual
sources.

>I've forwarded your patch to Ulrich & Martin ( the s390 maintainers ) &
>they may use it
>seeing as you & possibly others would prefer a /drivers/net/s390.

DaveM suggested a drivers/net/s390, I recommended against changing the
diretory structure right now, wait for 2.5.  My patch just changes the
compilation order for drivers/s390/net while keeping the same name.

[*] Extract from top level Makefile in my 2.5 rewrite.

# Link order information to build vmlinux.

link_subdirs(arch/$(ARCH)/boot)
link_subdirs(init)

link_subdirs($(arch_core_subdirs))

link_subdirs(kernel)
link_subdirs(mm)
link_subdirs(fs)
link_subdirs(ipc)

# FIXME: Built from the DRIVERS definitions in the old Makefile.  Some of this
# is just to link intermediate objects into the kernel, some of it is link order
# specific but the old Makefile had no documentation.  Preserve the old list,
# even though most of it is unnecessary.  The problem is, we do not know which
# bits are necessary because they have link order requirements.  Anybody feeling
# brave?  KAO

link_subdirs(drivers/block)
link_subdirs(drivers/char)
link_subdirs(drivers/misc)
link_subdirs(drivers/net)
link_subdirs(drivers/media)
...
link_subdirs(drivers/acpi)
link_subdirs(drivers/md)

link_subdirs($(arch_drivers_subdirs))

link_subdirs(net)

link_subdirs($(arch_libs))
link_subdirs(lib)