Re: softirq bugs in pre2

Pavel Machek (pavel@suse.cz)
Mon, 11 Jun 2001 23:58:46 +0200


Hi!

> diff -urN 2.4.4/include/linux/condsched.h lowlat/include/linux/condsched.h
> --- 2.4.4/include/linux/condsched.h Thu Jan 1 01:00:00 1970
> +++ lowlat/include/linux/condsched.h Sun Apr 29 18:33:13 2001
> @@ -0,0 +1,14 @@
> +#ifndef _LINUX_CONDSCHED_H
> +#define _LINUX_CONDSCHED_H
> +
> +#ifndef __ASSEMBLY__
> +#define conditional_schedule() \
> +do { \
> + if (current->need_resched) { \
> + current->state = TASK_RUNNING; \
> + schedule(); \
> + } \
> +} while(0)
> +#endif
> +
> +#endif

I do not think that conditional schedule is worth its own header
file. I see you want to potentiatlly replace it with assembly, but
can't that be done in, say, system.h too? [Ok, you'd have to create
linux/system.h, but that can be called cleanup.]
Pavel

-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/