Re: multicast hash incorrect on big endian archs

[David S. Miller]

Manfred Spraul writes:
 > That could cause alignment problems.
 > <<< from starfire.c
 > {
 >      long filter_addr;
 >      u16 mc_filter[32] __attribute__ ((aligned(sizeof(long)))); 
 > <<<
 > set_bit requires word alignment, but without the __attibute__ the
 > compiler would only guarantee 16-bit alignment. IMHO ugly.

Correction, it requires "long" alignment and that is 64-bits
on several platforms.

Later,
David S. Miller
[e-mail]