Re: PATCH: cs4232 isapnp support

[Andrzej Krzysztofowicz]

Hi,

> This adds ISAPnP support to cs4232.c.
[...]
> diff -u -r1.10 cs4232.c
> --- drivers/sound/cs4232.c	2001/05/27 18:06:09	1.10
> +++ drivers/sound/cs4232.c	2001/06/01 17:26:52
[...]
> @@ -318,22 +325,92 @@
>  static int __initdata mpuirq	= -1;
>  static int __initdata synthio	= -1;
>  static int __initdata synthirq	= -1;
> -
> +static int __initdata isapnp	= 1;

According to the comment in include/linux/init.h these are incorrect:

 * For initialized data:
 * You should insert __initdata between the variable name and equal
 * sign followed by value, e.g.:
 *
 * static int init_variable __initdata = 0;
 * static char linux_logo[] __initdata = { 0x32, 0x36, ... };
 *

AFAIR, moving the __initdata cause problems with some gcc versions.

Andrzej