Re: [PATCH] save source address on accept()

[David S. Miller]

Tim Hockin writes:
 > attached is a (small) patch which saves the src address on tcp_accept(). 
 > Please let me know if there are any problems taking this for general
 > inclusion.
 ..
 > --- dist-2.4.5/net/ipv4/tcp.c	Wed May 16 10:31:27 2001
 > +++ cobalt-2.4.5/net/ipv4/tcp.c	Thu May 31 14:33:23 2001
 > @@ -2138,6 +2138,7 @@
 >  		tp->accept_queue_tail = NULL;
 >  
 >   	newsk = req->sk;
 > +	newsk->rcv_saddr = req->af.v4_req.loc_addr;
 >  	tcp_acceptq_removed(sk);
 >  	tcp_openreq_fastfree(req);
 >  	BUG_TRAP(newsk->state != TCP_SYN_RECV);

Tim, this is in fact completely bogus, it is already being done
in tcp_v{4,6}_syn_recv_sock(), so there is no reason to do the
exact same thing again here in tcp_accept().

Later,
David S. Miller
[e-mail]