Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

[Nico Schottelius]

Daniel Phillips wrote:

> On Wednesday 30 May 2001 17:25, Ingo Molnar wrote:
> > On Wed, 30 May 2001, Nico Schottelius wrote:
> > > > the default value is 0, that is good enough.
> > >
> > > hmm.. I don't think so... value of 1 would be much better, because
> > > 0 normally disables the speaker.
> >
> > i confused the value. Yes, an initialization to 1 would be the
> > correct, ie.:
> >
> > +++ linux-2.4.5-nc/kernel/sysctl.c      Wed May  9 23:44:30 2001
> > @@ -48,6 +49,7 @@
> >  extern int nr_queued_signals, max_queued_signals;
> >  extern int sysrq_enabled;
> >
> > +int pcspeaker_enabled = 1;
>
> I'd go and change the whole patch so that speaker_disabled = 0 is the
> default, but that's just me.

Hmm...I thinking positive is more likely for humans, and double
negotation, like "not_disable" is less taken than just "enable".

So I agree with ingo, just setting pcspeaker_enabled = 1 at
normal would be the very best way.

Just after discussing about that, is it possible
someone adds the final patch ?

Nico