Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

[Dawson Engler]

> > drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn
> > 'DoC_Probe' calling init fn 'doccheck'
> 
> Strictly speaking, not actually a bug. DoC_Probe() itself is only ever 
> called from __init code. But it's probably not worth trying to make the 
> checker notice that situation - I've fixed it anyway by making DoC_Probe() 
> __init too, which saves a bit more memory. Thanks.

It's a space/performance bug, though, right?  From the original mail:

        1. The best case: the caller should actually be an __init function
        as well.  This is a performance bug since it won't be freed.