Re: [CHECKER] 84 bugs in 2.4.4/2.4.4-ac8 where NULL pointers are

Alexander Viro (viro@math.psu.edu)
Tue, 29 May 2001 18:36:13 -0400 (EDT)


On Tue, 29 May 2001, Dawson Engler wrote:

> [BUG] seems like it. it's not guarded. or is there some weird dependence?
> /u2/engler/mc/oses/linux/2.4.4-ac8/fs/ext2/dir.c:61:ext2_check_dir_entry: ERROR:INTERNAL_NULL:53:61: [type=set] (set at line 53) Dereferencing NULL ptr "dir" illegally!

No, it's simply a lump of fossilized crap. However, adding one more check
here is not a solution - it only adds to ugliness. The real fix is to get
rid of checking simgle entries and do all checks when we read the page -
at that point we obviously have the inode. Same goes for the second one.

Patch is available - see ftp.math.psu.edu/pub/viro/ext2-dir-patch-S4.gz
It's going to be very early 2.5.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/