Brown-paper-bag bug in m68k, sparc, and sparc64 config files

Eric S. Raymond (esr@thyrsus.com)
Sat, 19 May 2001 18:10:26 -0400


This bug unconditionally disables a configuration question -- and it's
so old that it has propagated across three port files, without either
of the people who did the cut and paste for the latter two noticing it.

This sort of thing would never ship in CML2, because the compiler
would throw an undefined-symbol warning on BLK_DEV_ST. The temptation
to engage in sarcastic commentary at the expense of people who still
think CML2 is an unnecessary pain in the butt is great. But I will
restrain myself. This time.

--- arch/m68k/config.in 2001/05/19 21:36:57 1.1
+++ arch/m68k/config.in 2001/05/19 21:37:12
@@ -192,7 +192,7 @@
int 'Maximum number of SCSI disks that can be loaded as modules' CONFIG_SD_EXTRA_DEVS 40
fi
dep_tristate ' SCSI tape support' CONFIG_CHR_DEV_ST $CONFIG_SCSI
- if [ "$CONFIG_BLK_DEV_ST" != "n" ]; then
+ if [ "$CONFIG_CHR_DEV_ST" != "n" ]; then
int 'Maximum number of SCSI tapes that can be loaded as modules' CONFIG_ST_EXTRA_DEVS 2
fi
dep_tristate ' SCSI CD-ROM support' CONFIG_BLK_DEV_SR $CONFIG_SCSI
--- arch/sparc/config.in 2001/05/19 21:34:54 1.1
+++ arch/sparc/config.in 2001/05/19 21:35:21
@@ -162,7 +162,7 @@

dep_tristate ' SCSI tape support' CONFIG_CHR_DEV_ST $CONFIG_SCSI

- if [ "$CONFIG_BLK_DEV_ST" != "n" ]; then
+ if [ "$CONFIG_CHR_DEV_ST" != "n" ]; then
int 'Maximum number of SCSI tapes that can be loaded as modules' CONFIG_ST_EXTRA_DEVS 2
fi

--- arch/sparc64/config.in 2001/05/19 21:37:33 1.1
+++ arch/sparc64/config.in 2001/05/19 21:37:45
@@ -146,7 +146,7 @@

dep_tristate ' SCSI tape support' CONFIG_CHR_DEV_ST $CONFIG_SCSI

- if [ "$CONFIG_BLK_DEV_ST" != "n" ]; then
+ if [ "$CONFIG_CHR_DEV_ST" != "n" ]; then
int 'Maximum number of SCSI tapes that can be loaded as modules' CONFIG_ST_EXTRA_DEVS 2
fi

-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

Conservatism is the blind and fear-filled worship of dead radicals. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/