Re: [patch] 2.4.0, 2.2.18: A critical problem with tty_io.c

[Alan Cox]

> - implements tty->ldisc_sem to plug race between do_tty_hangup()
>   and tty_set_ldisc().  Is this the ldisc race to which you refer?

Actually I'd missed that one. I was referring to the module race on the ldisc

> +#ifdef CONFIG_MODULES
> +	struct module *owner;
> +#endif

I'd rather the field was always there.  THIS_MODULE is correctly NULL for non
modules. Doing that makes all the ifdefs vanish and probably makes it a lot
more likely to pass Linus