Oh yes, I'm well aware it, that's what I mean by the "bullet proofing"
item on my to-do list. I don't quite agree with the idea of embedding
the checking of directory entry format inside the ext2_get_page
routine, it should be moved outside ext2_get_page, on basic principal.
Never mind that this routine is only used to get pages of directory
files, it's still not nice. Anyway, I think the thing to do is graft a
similar one-time check onto ext2_bread. We can't use Al's PG_checked
mechanism because we might have read only one buffer out of several on
the page.
> It turns out that in adding the checks for rec_len, I fixed my
> original bug, but added another... Please disregard my previous
> patch.
In any event, I couldn't apply it due to patch giving a 'malformed'
error - did you edit it after diffing? I'll wait for a revised patch -
there's quite a lot of stuff in there including formatting changes,
ext2 warnings, etc.
-- Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/