Re: [PATCH] Small kernel-api addition

David Woodhouse (dwmw2@infradead.org)
Thu, 10 May 2001 19:05:05 +0100

moz@compsoc.man.ac.uk said:
+ * This macro should be used for accessing values larger in size than single
+ * bytes at locations that may be improperly aligned, e.g. retrieving a u16
+ * value from a location not u16-aligned.

I'd suggest s/that may be/that are expected to be/

If it's _expected_, then by all means use {get,put}_unaligned(). If it's
normally going to be aligned, and it _may_ occasionally be otherwise, let
the common case go fast, and let the fixup handle it otherwise.

--
dwmw2




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/