Re: [patch] swap-speedup-2.4.3-B3 (fwd)

[Mike Galbraith]

On Thu, 26 Apr 2001, Linus Torvalds wrote:

> Have you looked at "free_pte()"? I don't like that function, and it might
> make a difference. There are several small nits with it:

snip

> I _think_ the logic should be something along the lines of: "freeing the
> page amounts to a implied down-aging of the page, but the 'accessed' bit
> would have aged it up, so the two take each other out". But if so, the
> free_pte() logic should have something like
>
> 	if (page->mapping) {
> 		if (!pte_young(pte) || PageSwapCache(page))
> 			age_page_down_ageonly(page);
> 		if (!page->age)
> 			deactivate_page(page);
> 	}

Hi,

I tried this out today after some more reading.

virgin pre7 +Rik
real    11m44.088s
user    7m57.720s
sys     0m36.420s

+Rik +Linus
real    11m48.597s
user    7m55.620s
sys     0m37.860s

+Rik +Linus +HarshAging
real    11m17.758s
user    7m57.650s
sys     0m36.350s

None of them make much difference.

	-Mike