Re: [RFC][PATCH] adding PCI bus information to SCSI layer

Jeff Garzik (jgarzik@mandrakesoft.com)
Mon, 23 Apr 2001 22:14:53 -0400


Matt_Domsch@Dell.com wrote:
>
> > PCI ids can be derived from bus/slot/function.
>
> Even better. I'll remove the extraneous fields then, and only return those.
>
> typedef struct scsi_pci {
> unsigned char bus_number;
> unsigned int devfn; /* encoded device & function index
> */
> } Scsi_Pci;

Why not pci_dev::slot_name? Presumeably the only reason you need this
is to export it to userspace... We already have the ASCII text there,
please consider using that :)

-- 
Jeff Garzik      | The difference between America and England is that
Building 1024    | the English think 100 miles is a long distance and
MandrakeSoft     | the Americans think 100 years is a long time.
                 |      (random fortune)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/