[PATCH] Problem in lxdialog (was: menuconfig snafu?)

[Moritz Schulte]

Dennis <[e-mail]> writes:

Hi,

> its seems that "make menuconfig" only allows you to select 1
> processor type. it seems impossible that you cant build a generic
> kernel that supports different processors. Its this just a
> menuconfig bug?

I think, that's the same problem like the one i found in lxdialog...

  I've already sent a report+patch to
[e-mail] and to the menuconfig maintainer,
but nobody has answered yet. Here it is:

  I think, I've found a problem with the changes to
linux/scripts/lxdialog/checklist.c, which were introduced in Linux
2.2.19pre8. The problem is, that several calls to wrefresh() were
changed to wnoutrefresh(), but a doupdate() is missing. I'm seeing
broken dialogs here, for example in the 'Processor family'
checklist. I'm using libncurses 5.0 (5.0-6.0potato1). With the
following patch, the problem seems to be fixed. Is the Patch correct?

--- linux/scripts/lxdialog/checklist.c.orig	Mon Mar 26 23:28:47 2001
+++ linux/scripts/lxdialog/checklist.c	Mon Mar 26 23:29:08 2001
@@ -211,13 +211,15 @@
 		    status[i+scroll], i, i == choice);
     }
 
-    wnoutrefresh (list);
-
     print_arrows(dialog, choice, item_no, scroll,
 			box_y, box_x + check_x + 5, list_height);
 
     print_buttons(dialog, height, width, 0);
 
+    wnoutrefresh (list);
+    wnoutrefresh (dialog);
+    doupdate ();
+
     while (key != ESC) {
 	key = wgetch (list);
 
@@ -355,7 +357,11 @@
 	case ESC:
 	    break;
 	}
+
+	/* Now, update everything... */
+	doupdate ();
     }
+    
 
     delwin (dialog);
     free (status);

bye,
	moritz
-- 
Moritz Schulte <[e-mail]> http://www.chaosdorf.de/moritz/
Debian/GNU supporter - http://www.debian.org/ http://www.gnu.org/
GPG fingerprint = 3A14 3923 15BE FD57 FC06  B501 0841 2D7B 6F98 4199