Re: [CHECKER] 4 warnings in kernel/module.c

Junfeng Yang (yjf@stanford.edu)
Fri, 23 Mar 2001 11:56:45 -0800 (PST)


On Fri, 23 Mar 2001, Keith Owens wrote:

> On Fri, 23 Mar 2001 02:41:40 -0800 (PST),
> Junfeng Yang <yjf@stanford.edu> wrote:
> >Hi, we modified the block checker and run it again on linux 2.4.1. (The
> >block checker flags an error when blocking functions are called with
> >either interrupts disabled or a spin lock held. )
> >
> >It gave us 4 warnings in kernel/module.c. Because we are unaware of the
> >contexts where these functions are called, we are not sure if these 4
> >warnings are real errors or false positives. Please help us to verify them
> >or show that they are false positives.
>
> All false positives. The big kernel lock is a special case, you are
> allowed to sleep while holding that lock. See release_kernel_lock()
> and reacquire_kernel_lock() in sched().

Thanks for pointing this out. We'll modify the checker again and remove
"lock_kernel" from the patterns.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/