Re: [CHECKER] 120 potential dereference to invalid pointers errors

[Benjamin Chelf]

Hi,

  I'm interested in one specific "bug" reported out of these 120 and
no one seems to have responded about it yet. It reports the error on
line 889 (drivers/scsi/sd.c), but line 825 also seems bad (memsetting
the pointer that was allocated before checking for NULL). This piece
of code seems to go back to the 1.0 version of the kernel, hence my
suspcision about it actually being a bug. Anyone have thoughts about
it? Thanks!

-ben

---------------------------------------------------------
[BUG] scsi_malloc can return NULL. it should find error at line 756

2.4.1/drivers/scsi/sd.c:889:sd_init_onedisk:
ERROR:NULL:738:889: Using unknown ptr "buffer" illegally! set by
'scsi_malloc':738

Start --->
        buffer = (unsigned char *) scsi_malloc(512);

        spintime = 0;

        /* Spin up drives, as required.  Only do this at boot time */

        ... DELETED 143 lines ...

                rscsi_disks[i].capacity = 1 + ((buffer[0] << 24) |
                                               (buffer[1] << 16) |
                                               (buffer[2] << 8) |
Error --->
                                               buffer[3]);

---------------------------------------------------------