Re: [PATCH] Re: [PATCH] Re: [PATCH] 2.4.3-pre6 - hdlc/dscc4 missing bits

[Jeff Garzik]

Francois Romieu wrote:
> 
> Jeff Garzik <[e-mail]> écrit :
> > You should use this patch instead, from Alan's tree, for updating
> > include/linux/if_arp.h...
> 
> It adds confusion: do you imagine the poor soul who discovers hdlc in Linux
> and sees ARPHRD_CISCO and ARPHRD_HDLC for the same use after some hours
> of code-greping (both will be used at the moment if hdlc.c do so) ?
> Don't be surprised if he ends using label pointers everywhere. :o)
> 
> What about the following (2.5 ?):

That looks like 2.5 material to me.  Personally I wouldn't want to
remove identifiers during 2.4 stable series..  Changing all 2.4 code to
use one identifier or the other seems reasonable.

Make sure to sync with Alan.  WAN stuff has been occurring in his tree,
and we want to make sure everybody's on the same page..

-- 
Jeff Garzik       | May you have warm words on a cold evening,
Building 1024     | a full mooon on a dark night,
MandrakeSoft      | and a smooth road all the way to your door.