Re: d_add on negative dentry?

[Alexander Viro]

On Tue, 6 Mar 2001, Urban Widmark wrote:

> 
> Is it valid to call d_add on a negative dentry?
> (or on a dentry that is already linked in d_hash, but all negative
>  dentries are, right?)

Not all of them. It _is_ legal to do d_add() on a negative dentry.
Doing that for hashed dentries is a bug. Use d_instantiate() instead.
							Cheers,
								Al

PS: as for the patch, better make it
	d_instantiate(...);
	if (!hashed)
		d_rehash(...);