Re: [PATCH] drivers/char/serial.c unchecked ioremap() calls

[Andrey Panin]

--uAKRQypu60I7Lcqm
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2001 at 09:15:29AM -0500, Jeff Garzik wrote:
> Arnaldo Carvalho de Melo wrote:
> >=20
> > Em Fri, Feb 23, 2001 at 10:53:59AM +0300, Andrey Panin escreveu:
> > >
> > > Hi all,
> > >
> > > 16x50 serial driver doesn't check ioremap() return value.
> > > Atached patch should fix this it.
> >=20
> > humm, have not checked, but it seems as if you don't release the previo=
us
> > successful mappings on failure. Wipe out this message if I was too quic=
k to
> > answer and this is not true. 8)
>=20
> Also, the proper return from a failed ioremap is -ENOMEM, so I think
> Andrey's serial.c patch should modify some functions to return a failure
> code...
>=20

All these ioremap() failures are not fatal,=20
just fail to init one PCI/ISAPNP device or one serial port.
IMHO a warning message will be enough for them :)

--=20
Andrey Panin            | Embedded systems software engineer
[e-mail]        | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin=
.asc

--uAKRQypu60I7Lcqm
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE6mnD4Bm4rlNOo3YgRAqeUAJwPiKrPeU3rO1V/DSw3brUHKWeBrQCfcxR5
WAuOYOlHgMyxF/MpydSJJ+Y=
=pjwN
-----END PGP SIGNATURE-----

--uAKRQypu60I7Lcqm--