Re: [PATCH] 2.4.x kernel keyboard fix for Digital HiNote Ultra 2000

[Alan Cox]

> drivers/char/pc_keyb.c related to fixing problems on a Toshiba 4030cdt.
> It would appear that the fix for the Tosh, breaks the HiNote. (I don't
> have a Tosh to experiment with).

Reading the pc_keyb.c code two things strike me. The first is to wonder how
the hell Linus let that code get submitted ;) and the second is that the
delay rules are totally violated, and thats something we know the hinote's
hate.

> --- drivers/char/pc_keyb.c.orig Sat Feb 24 20:01:46 2001
> +++ drivers/char/pc_keyb.c      Sat Feb 24 20:02:03 2001
> @@ -909,7 +909,7 @@
>         aux_write_ack(AUX_ENABLE_DEV); /* Enable aux device */
>         kbd_write_cmd(AUX_INTS_ON); /* Enable controller ints */
> 
> -       send_data(KBD_CMD_ENABLE);      /* try to workaround
> toshiba4030cdt problem */
> +//     send_data(KBD_CMD_ENABLE);      /* try to workaround
> toshiba4030cdt problem */

Instead of commenting it put

	mdelay(1);

before and after, and let me know if that helps

Alan