Re: cpu_has_fxsr or cpu_has_xmm?

[H. Peter Anvin]

Followup to:  <[e-mail]>
By author:    "Quim K Holland" <[e-mail]>
In newsgroup: linux.dev.kernel
>
> I've been looking at various -ac patches for the last couple of 
> weeks and have been wondering why only this piece of difference
> still remains between Linus' 2.4.2 and Alan's -ac2.  All the other
> diffs in i387.c from 2.4.1-ac2 seem to have been merged into Linus
> tree at around 2.4.2-pre1.  Could anybody explain it for me please?
> 
> --- linux.vanilla/arch/i386/kernel/i387.c       Thu Feb 22 09:05:35 2001
> +++ linux.ac/arch/i386/kernel/i387.c    Sun Feb  4 10:58:36 2001
> @@ -179,7 +179,7 @@
>  
>  unsigned short get_fpu_mxcsr( struct task_struct *tsk )
>  {
> -       if ( cpu_has_fxsr ) {
> +       if ( cpu_has_xmm ) {
>                 return tsk->thread.i387.fxsave.mxcsr;
>         } else {
>                 return 0x1f80;
> 

IMO, XMM is correct here; FXSR is incorrect.  Linus?

	-hpa
-- 
<[e-mail]> at work, <[e-mail]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt