Re: [beta patch] SSE copy_page() / clear_page()

[Manfred Spraul]

Pavel Machek wrote:
> 
> > > > +         __asm__ __volatile__(
> > > > +                 "mov %1, %0\n\t"
> > > > +                 : "=r" (i)
> > > > +                 : "r" (kaddr+offset)); /* load tlb entry */
> > > > +         for(i=0;i<size;i+=64) {
> > > > +                 __asm__ __volatile__(
> > > > +                         "prefetchnta (%1, %0)\n\t"
> > > > +                         "prefetchnta 32(%1, %0)\n\t"
> > > > +                         : /* no output */
> > > > +                         : "r" (i), "r" (kaddr+offset));
> > > > +         }
> > > > + }
> > > >   left = __copy_to_user(desc->buf, kaddr + offset, size);
> > > >   kunmap(page);
> > >
> > > This seems bogus -- you need to handle faults --
> > > i.e. __prefetchnta_to_user() ;-).
> >

Ahm. That's file_read_actor, not file_write_actor ;-)
I'm prefetching the kernel space buffer.

> > It wants wrapping nicely. A generic prefetch and prefetchw does help some other
> > cases (scheduler for one).
> >
> > Does the prefetch instruction fault on PIII/PIV then - the K7 one appears not
> > to be a source of faults
> 
> My fault. I was told that prefetch instructions are always
> non-faulting.
>

But there is another problem:

The tlb preloading with a simple 'mov' is not enough:
the Pentium III cpu decodes the 'mov', begins to load the tlb entry -
this will take at least several dozend cpu ticks.

But the cpu continues to decode further instructions. It sees the
'prefetchnta', notices that the tlb entry is not loaded and ignores the
next prefetchnta's (prefetch without tlb is turned into NOP).

--	
	Manfred