Re: Linux 2.4.1-ac15

[Philipp Rumpf]

On Mon, 19 Feb 2001, Alan Cox wrote:
> > So you fixed the nonexistent race only.  The real race is that the module
> 
> Umm I fixed the small race. You are right that there is a second race.

There's just one race.  The small race is nonexistent since
put_mod_name always acts as a memory barrier.

> > uninitialized vmalloc'd (module_map'd) memory), then the module data
> > (including the exception table) gets copied.
> > The race window is from the first copy_from_user in sys_init_module until
> > the second one.
> 
> Yep. Obvious answer. Ignore exception tables for modules that are not
> MOD_RUNNING.

You can have exceptions while initializing.  not
MOD_RUNNING|MOD_INITIALIZING should work though.