Re: [PATCH] minor ne2k-pci irq fix

Martin Diehl (mdiehlcs@compuserve.de)
Thu, 1 Feb 2001 01:01:40 +0100 (CET)


On Wed, 31 Jan 2001 davej@suse.de wrote:

> I think it would be better to move the pci_enable_device(pdev);
> above all this, as we should enable the device before reading the
> pdev->resource[] too iirc.

Probably I've missed this because the last time I hit such a thing was
when my ob800 bios mapped the cardbus memory BAR's into bogus legacy
0xe0000 area. Hence there was good reason to read and correct this before
trying to enable the device.
The normal case however would be like you've suggested, IMHO.

BTW, will it ever happen the kernel starts remapping BAR's when enabling
devices?

Regards
Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/