Re: [PATCH] No VIA IDE DMA unless configured

[Stephen Clark]

Guys,

from .config on 2.4.1
CONFIG_BLK_DEV_IDEDMA_PCI=y
# CONFIG_BLK_DEV_OFFBOARD is not set
CONFIG_IDEDMA_PCI_AUTO=y
CONFIG_BLK_DEV_IDEDMA=y

Shouldn' t the value be CONFIG_IDEDMA_PCI_AUTO instead of CONFIG_IDEDMA_AUTO
in the code below?

Steve

Vojtech Pavlik wrote:

> On Tue, Jan 23, 2001 at 10:46:14PM +0100, Tobias Ringstrom wrote:
>
> > Linus, please consider this patch for 2.4.1.  It makes sure the VIA IDE
> > driver does not enable DMA automatically, unless the user has requested it
> > using "make whateverconfig".
> >
> > /Tobias
> >
> > --- via82cxxx.c.orig  Tue Jan 23 22:26:25 2001
> > +++ via82cxxx.c       Tue Jan 23 22:27:05 2001
> > @@ -602,7 +602,9 @@
> >  #ifdef CONFIG_BLK_DEV_IDEDMA
> >       if (hwif->dma_base) {
> >               hwif->dmaproc = &via82cxxx_dmaproc;
> > +#ifdef CONFIG_IDEDMA_AUTO
> >               hwif->autodma = 1;
> > +#endif /* CONFIG_IDEDMA_AUTO */
> >       }
> >  #endif /* CONFIG_BLK_DEV_IDEDMA */
> >  }
> >
>
> Linus, if you haven't applied my disable-dma-in-all-cases patch I've
> sent you earlier, please do apply this one - it's correct and should be
> there. It conflicts with the older one, obviously.
>
> --
> Vojtech Pavlik
> SuSE Labs
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [e-mail]
> Please read the FAQ at http://www.tux.org/lkml/