Re: [PATCH] guard mm->rss with page_table_lock (241p11)

Rasmus Andersen (rasmus@jaquet.dk)
Tue, 30 Jan 2001 12:38:12 +0100


On Tue, Jan 30, 2001 at 09:23:27AM -0200, Rik van Riel wrote:
> Why bother ?
>
> In most places where we update mm->rss, we are *already*
> holding the spinlock anyway, this correction is just for
> a few places.
>
> The big patch Rasmus made seems to contain spin_lock(&foo)
> in places where we already have the lock, leading to
> instant SMP deadlock. I suspect Rasmus' patch should be
> about half the size it is currently...

After donning my brown paper bag yesterday I looked at
the call-paths again and removed one more lock pair
(the one in swapfile). The others seemed OK so I made
a SMP-on-UP kernel and ran my usual stuff (X, mozilla,
kernel compiles) alongside mmap001, mmap002 and misc001
with no ill effects.

I will beat on it some more today and tomorrow, but if
real SMP is needed for testing I need some help to do
that.

Regards,
Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/