Re: [PATCH] make drivers/scsi/seagate.c use ioremap instead of

[Brian Gerst]

Rasmus Andersen wrote:
> 
> Hi.
> 
> (I have not been able to find a probable current maintainer for
> this code.)
> 
> The following patch makes drivers/scsi/seagate.c use ioremap
> instead of isa_{read, write}.
> 
> It applies against ac12 and 241p11.
> 
> Please comment, esp. on the size of the remappings.

This isn't the proper way to use ioremap.  You should only ioremap once
when the driver is loaded and save the mapped address.  Since ioremap
special cases ISA addresses, it doesn't add much overhead the way you
are doing it, but it is still not consistent with normal non-ISA usage
of ioremap.

--

				Brian Gerst