Re: flush_scheduled_tasks() question

[David Woodhouse]

[e-mail] said:
> Is is intentional that tummy_task is not initialized? 

It _is_ initialised. To zero :)

> Ok, it won't crash because the current __run_task_queue()
> implementation doesn't call tq->routine if it's NULL, but IMHO it's
> ugly.

-static struct tq_struct dummy_task;
+static struct tq_struct dummy_task /* = all zero */;

[e-mail] said:
>  Additionally I don't like the loop in flush_scheduled_tasks(), what
> about replacing it with a locked semaphore (same idea as vfork)?

The reason for doing it that way was because there was no guarantee that 
scheduled tasks will be called in order. So you can't just stick a new task 
in the queue and assume that when it's completed the queue is flushed. 

Linus then changed that and made the eventd thread call tasks in order, but 
I believe the intention is still that we don't make that guarantee, so it 
may change at any point in the future. 

--
dwmw2