Re: [PATCH](s): Use spinlocks instead of STI/CLI in SoundBlaster

[Chris Rankin]

> spin_lock_irqsave() and save_flags()+cli() are identical on
> uniprocessor builds.

OK, so a UP-build proves nothing ...

> cli() is quite putrid on SMP and should be shot.

This much I understand ...

> You can test your patch on uniprocessor hardware - just build
> an SMP kernel and run it.  If it doesn't deadlock, things
> are looking positive.

OK, I'll do that.

> I dunno if you'll have much luck getting this into 2.4.1 though.
> I suggest you send it to Alan.

I have no illusions whatsoever about Linus picking this up. However,
Alan has been picking patches up I've posted before. I can't send this
to Alan directly though, because his mailserver keeps on asking for
the average airspeed of an unladen swallow ... (I don't know that!)

Cheers,
Chris