Re: BUG in modutils or drivers/isdn/hisax/

[Ingo Oeser]

Hi Karsten,

On Tue, Jan 23, 2001 at 12:28:49PM +0100, Karsten Keil wrote:
> > the current modutils (2.4.1) cannot read the
> > __module_pci_device_table of a kernel/drivers/isdn/hisax/hisax.o
> > module of linux 2.4.0 (vanilla).
> > 
> > What's wrong with it?
> 
> Nothing. Only the HFC-PCI part in hisax has such a table yet, all other
> card drivers in hisax don't have one at the moment.

To quote drivers/isdn/hisax/config.c:1710-1713
static struct pci_device_id hisax_pci_tbl[] __initdata = {
#ifdef CONFIG_HISAX_FRTIZPCI
        {PCI_VENDOR_ID_AVM,      PCI_DEVICE_ID_AVM_FRITZ,       PCI_ANY_ID, PCI_ANY_ID},
#endif

To quote my .config:
CONFIG_ISDN_DRV_HISAX=m
CONFIG_HISAX_FRITZPCI=y

So the bug is indeed in the driver and is a speling mistake
Patch is:

--- linux/drivers/isdn/hisax/config.c.orig	Fri Dec 29 23:07:22 2000
+++ linux/drivers/isdn/hisax/config.c	Tue Jan 23 15:07:54 2001
@@ -1708,8 +1708,8 @@
 }
 
 static struct pci_device_id hisax_pci_tbl[] __initdata = {
-#ifdef CONFIG_HISAX_FRTIZPCI
-	{PCI_VENDOR_ID_AVM,      PCI_DEVICE_ID_AVM_FRITZ,        PCI_ANY_ID, PCI_ANY_ID},
+#ifdef CONFIG_HISAX_FRITZPCI
+	{PCI_VENDOR_ID_AVM,      PCI_DEVICE_ID_AVM_FRITZ,	PCI_ANY_ID, PCI_ANY_ID},
 #endif
 #ifdef CONFIG_HISAX_DIEHLDIVA
 	{PCI_VENDOR_ID_EICON,    PCI_DEVICE_ID_EICON_DIVA20,     PCI_ANY_ID, PCI_ANY_ID},

Please apply.

Regards

Ingo Oeser
-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<       come and join the fun       >>>>>>>>>>>>