Re: [PATCH] Fix compile warnings in 2.4.0

[Rich Baum]

On 8 Jan 2001, at 11:52, Keith Owens wrote:

> On Sun, 7 Jan 2001 16:19:50 -0500, 
> "Rich Baum" <[e-mail]> wrote:
> >This patch should fix the rest of the warnings about #endif 
> >statements when using the 20001225 gcc snapshot.  Thanks to 
> >Keith Owens for providing a script to automate this process.  It got 
> >the job done sooner and found warnings to fix for non x86 platforms.
> 
> As reported by Neil Booth, your patch contains errors which do not
> appear in my patched system using my script.  You probably skipped the
> leading '^' in the regexp.  It also turns out that there are a couple
> of m68k assembler lines which have a trailing '#' which starts a
> comment on that assembler.  So treat '#' as a comment marker as well.
> 
> Whatever you used, it was not my script.  It should be (with '#' added)
> 
>   find -type f -name '*.[chS]' | \
>     xargs perl -lpi -e 's:^(\s*#\s*endif)\s+([^/\s#].*)$:\1\t/* \2 */:;'
> 
> BTW, until the patch is correct do not bother sending it to Alan Cox or
> Linus, just to linux-kernel..
> 
You're right I left off the first ^.  From know on I'll just go back to my 
method of checking my compile logs for errors and manually fixing 
them.  I'll let other people handle non x86 platforms.