RE: [PTACH] wrong stat of NTFS volume in linux-kernel 2.4.0

[Anton Altaparmakov]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to [e-mail] for more info.

---559023410-851401618-978952425=:17453
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <[e-mail]>

Willem,

First of all thanks for tracking down this bug! Keep up the good work.

I have produced a IMHO more elegant solution (see attached patch) which
doesn't require introducing the ugly divide function by using the
asm/bitops.h::ffs() function and then replacing all clusterfactor
arithmetic with shifts by the (new) clusterfactorbits. In fact the
clusterfactor is completely replaced by the clusterfactorbits in the
driver.

The patch has been submitted to Alan for inclusion in the 2.4.0-ac series
as Linus at present only accepts critical patches which this clearly is
not.

btw. Patch is tested and works fine.

Best regards,

	Anton Altaparmakov

-- 
Anton Altaparmakov       Phone: [phone] (lab)
Christ's College         eMail: [e-mail]
Cambridge CB2 3BU          WWW: http://www-stu.christs.cam.ac.uk/~aia21/
United Kingdom             ICQ: 8561279

---559023410-851401618-978952425=:17453
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="ntfs_df_fix.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <[e-mail]>
Content-Description: 

LS0tIGxpbnV4L2ZzL250ZnMvc3VwZXIub2xkCU1vbiBKYW4gIDggMDk6MDg6
MTAgMjAwMQ0KKysrIGxpbnV4L2ZzL250ZnMvc3VwZXIuYwlNb24gSmFuICA4
IDAyOjM2OjMzIDIwMDENCkBAIC0xMiw2ICsxMiw3IEBADQogI2luY2x1ZGUg
InN1cGVyLmgiDQogDQogI2luY2x1ZGUgPGxpbnV4L2Vycm5vLmg+DQorI2lu
Y2x1ZGUgPGFzbS9iaXRvcHMuaD4NCiAjaW5jbHVkZSAibWFjcm9zLmgiDQog
I2luY2x1ZGUgImlub2RlLmgiDQogI2luY2x1ZGUgInN1cHBvcnQuaCINCkBA
IC03NSw3ICs3Niw3IEBADQogDQogCS8qIFNlY3RvciBzaXplICovDQogCXZv
bC0+YmxvY2tzaXplPU5URlNfR0VUVTE2KGJvb3QrMHhCKTsNCi0Jdm9sLT5j
bHVzdGVyZmFjdG9yPU5URlNfR0VUVTgoYm9vdCsweEQpOw0KKwl2b2wtPmNs
dXN0ZXJmYWN0b3JiaXRzID0gZmZzKE5URlNfR0VUVTgoYm9vdCsweEQpKSAt
IDE7DQogCXZvbC0+bWZ0X2NsdXN0ZXJzX3Blcl9yZWNvcmQ9TlRGU19HRVRT
OChib290KzB4NDApOw0KIAl2b2wtPmluZGV4X2NsdXN0ZXJzX3Blcl9yZWNv
cmQ9TlRGU19HRVRTOChib290KzB4NDQpOw0KIAkNCkBAIC05NSw3ICs5Niw3
IEBADQogCWlmKHZvbC0+bWZ0X2NsdXN0ZXJzX3Blcl9yZWNvcmQ8MCAmJiB2
b2wtPm1mdF9jbHVzdGVyc19wZXJfcmVjb3JkIT0tMTApDQogCQludGZzX2Vy
cm9yKCJVbmV4cGVjdGVkIGRhdGEgIzQgaW4gYm9vdCBibG9ja1xuIik7DQog
DQotCXZvbC0+Y2x1c3RlcnNpemU9dm9sLT5ibG9ja3NpemUqdm9sLT5jbHVz
dGVyZmFjdG9yOw0KKwl2b2wtPmNsdXN0ZXJzaXplID0gdm9sLT5ibG9ja3Np
emUgPDwgdm9sLT5jbHVzdGVyZmFjdG9yYml0czsNCiAJaWYodm9sLT5tZnRf
Y2x1c3RlcnNfcGVyX3JlY29yZD4wKQ0KIAkJdm9sLT5tZnRfcmVjb3Jkc2l6
ZT0NCiAJCQl2b2wtPmNsdXN0ZXJzaXplKnZvbC0+bWZ0X2NsdXN0ZXJzX3Bl
cl9yZWNvcmQ7DQpAQCAtMzIyLDcgKzMyMyw3IEBADQogCWlvLmRvX3JlYWQ9
MTsNCiAJaW8uc2l6ZT12b2wtPmNsdXN0ZXJzaXplOw0KIAludGZzX2dldHB1
dF9jbHVzdGVycyh2b2wsMCwwLCZpbyk7DQotCSp2b2xfc2l6ZSA9IE5URlNf
R0VUVTY0KGNsdXN0ZXIwKzB4MjgpOw0KKwkqdm9sX3NpemUgPSBOVEZTX0dF
VFU2NChjbHVzdGVyMCsweDI4KSA+PiB2b2wtPmNsdXN0ZXJmYWN0b3JiaXRz
Ow0KIAludGZzX2ZyZWUoY2x1c3RlcjApOw0KIAlyZXR1cm4gMDsNCiB9DQot
LS0gbGludXgvZnMvbnRmcy9zdHJ1Y3Qub2xkCU1vbiBKYW4gIDggMDI6Mzc6
MTggMjAwMQ0KKysrIGxpbnV4L2ZzL250ZnMvc3RydWN0LmgJTW9uIEphbiAg
OCAwMjozNToxNSAyMDAxDQpAQCAtNTQsNyArNTQsNyBAQA0KIAludGZzX3Uz
MiBhdF9zeW1saW5rOyAvKiBha2EgU1lNQk9MSUNfTElOSyBvciBSRVBBUlNF
X1BPSU5UICovDQogCS8qIERhdGEgcmVhZCBmcm9tIHRoZSBib290IGZpbGUg
Ki8NCiAJaW50IGJsb2Nrc2l6ZTsNCi0JaW50IGNsdXN0ZXJmYWN0b3I7DQor
CWludCBjbHVzdGVyZmFjdG9yYml0czsNCiAJaW50IGNsdXN0ZXJzaXplOw0K
IAlpbnQgbWZ0X3JlY29yZHNpemU7DQogCWludCBtZnRfY2x1c3RlcnNfcGVy
X3JlY29yZDsNCi0tLSBsaW51eC9pbmNsdWRlL2xpbnV4L250ZnNfZnNfc2Iu
b2xkCU1vbiBKYW4gIDggMDI6Mzc6NDYgMjAwMQ0KKysrIGxpbnV4L2luY2x1
ZGUvbGludXgvbnRmc19mc19zYi5oCU1vbiBKYW4gIDggMDI6Mzc6NTQgMjAw
MQ0KQEAgLTI2LDcgKzI2LDcgQEANCiAJbnRmc191MzIgYXRfc3ltbGluazsg
LyogYWthIFNZTUJPTElDX0xJTksgb3IgUkVQQVJTRV9QT0lOVCAqLw0KIAkv
KiBEYXRhIHJlYWQgZnJvbSB0aGUgYm9vdCBmaWxlICovDQogCWludCBibG9j
a3NpemU7DQotCWludCBjbHVzdGVyZmFjdG9yOw0KKwlpbnQgY2x1c3RlcmZh
Y3RvcmJpdHM7DQogCWludCBjbHVzdGVyc2l6ZTsNCiAJaW50IG1mdF9yZWNv
cmRzaXplOw0KIAlpbnQgbWZ0X2NsdXN0ZXJzX3Blcl9yZWNvcmQ7DQo=
---559023410-851401618-978952425=:17453--