Re: Module section warning

[Keith Owens]

On Fri, 5 Jan 2001 20:51:46 +0000 (GMT), 
Alan Cox <[e-mail]> wrote:
>> o  binutils               2.9.1.0.25              # ld -v
>> o  modutils               2.4.0                   # insmod -V
>> 
>> and 2.4 uses gas instead of as86 for real mode.
>> 
>> Are not that versions enough to delete the
>> __asm__(".section .modinfo\n\t.previous");
>> in module.h ?
>
>Firstly they are guidelines for x86. Secondly certain configs need the updates
>so its pretty invasive to force it yet - 2.5.0 yes

Any modutils >= 2.3.19 automatically treats .modinfo as no load,
irrespective of what the kernel says.  Since modutils 2.3.21 fixes the
local root exploit on modprobe, nobody on kernel 2.4 should be running
modutils < 2.3.21.  I am tempted to put a check in modules_install to
detect insecure modutils and bitch.

Modutils 2.4 is backwards compatible down to 2.0 kernels.  I have no
qualms about removing __asm__(".section .modinfo\n\t.previous"); from
module.h in 2.4 kernels and will be sending in patches to do that,
along with other changes to module.h.  Worst case when omitting that
line and still using old modutils is a slightly larger module in
memory.