Re: [patch] big udelay's in fb drivers (2.4.0-prerelease)

Oliver Xymoron (oxymoron@waste.org)
Thu, 4 Jan 2001 19:31:39 -0600 (CST)


On Fri, 5 Jan 2001, Alan Cox wrote:

> > Once the comments are unweirded, they become completely superfluous. At
> > which point its best not to have them - when someone next comes along and
> > changes the delay, it might end up disagreeing with the comment and
> > causing confusion.
>
> Before you remove the comments check with the author and the manuals.

Huh? Granted that's generally a good idea, but if you've got code that
says

udelay(15000); /* delay 15ms */

the comment is just extra baggage. No sense touching it generally, but if
you're gonna change it to mdelay..

-- 
 "Love the dolphins," she advised him. "Write by W.A.S.T.E.."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/