Re: usb dc2xx quirk

[David Brownell]

If this makes it go away, then by all means apply this patch;
though I don't quite see what the failure mode would be.

The proximate cause of that Oops looked to be in one of the
UHCI drivers, but of course it's also possible that it was
triggered by driver misbehavior.

Have we identified anything that actually does anything with
code labeled __dev{in,ex}it (or data), beyond putting it into
a different section?  If so, what's it doing?

I just tried plug/unplug of a dc-240, albeit on a kernel
with HOTPLUG defined (and using OHCI) and it worked without
any Oops.

- Dave

----- Original Message -----
From: Randy Dunlap <[e-mail]>
To: josh <[e-mail]>
Cc: <[e-mail]>; <[e-mail]>; l-u-d
<[e-mail]>
Sent: Wednesday, January 03, 2001 11:23 AM
Subject: Re: usb dc2xx quirk

> Hi,
>
> Looks like dc2xx.c shouldn't use __devinit/__devexit
> [patch attached]
> or you should enable CONFIG_HOTPLUG under General Setup.
>
> David?
>
> The ov511 (usb) driver is the only other USB device driver
> that uses __devinit/__devexit.
>
> ~Randy
>
> josh wrote:
> >
> > Kernel Version: 2.4.0-test11 - 2.4.0-prerelease
> > Platform: ix86 (PIII)
> > Problem Hardware: Kodac DC280, firmware 1.01
> >
> > Ever since test10 or after, removing my dc280 from the usb
> > bus causes khubd to crash.  I have tried both UHCI drivers
> > and they produce the same effect.
> >
> > dmesg, syslog, messages, and .config can be found at:
> > http://mammoth.org/~skulcap/usb-problem
> >
> > I have looked throug the archives and havent found anything
> > like this, so I'm sorry if it has been covered already.
> >
> > Thanks in advance!
> --
> _______________________________________________
> |randy.dunlap_at_intel.com        503-677-5408|
> |NOTE: Any views presented here are mine alone|
> |& may not represent the views of my employer.|
> -----------------------------------------------

--------------------------------------------------------------------------------

> --- linux/drivers/usb/dc2xx.c.org Sun Nov 12 20:40:42 2000
> +++ linux/drivers/usb/dc2xx.c Wed Jan  3 11:15:11 2001
> @@ -353,7 +353,7 @@
>
>
>
> -static void * __devinit
> +static void *
>  camera_probe (struct usb_device *dev, unsigned int ifnum, const struct usb_device_id
*camera_info)
>  {
>   int i;
> @@ -451,7 +451,7 @@
>   return camera;
>  }
>
> -static void __devexit camera_disconnect(struct usb_device *dev, void *ptr)
> +static void camera_disconnect(struct usb_device *dev, void *ptr)
>  {
>   struct camera_state *camera = (struct camera_state *) ptr;
>   int subminor = camera->subminor;
>