Re: [PATCH] filemap_fdatasync & related changes

[Chris Mason]

On Wednesday, January 03, 2001 10:28:05 AM -0800 Linus Torvalds
<[e-mail]> wrote:
 
> On Wed, 3 Jan 2001, Chris Mason wrote:
>> 
>> Just noticed the filemap_fdatasync code doesn't check the return value
>> from writepage.  Linus, would you take a patch that redirtied the page,
>> puts it back onto the dirty list (at the tail), and unlocks the page
>> when writepage returns 1?
> 
> I don't see how that would help. It's just asking for endless loops.
> 
Yes, we would be explictly saying it is an error to always return 1.

The problem with [mf]sync is that we really want to write the page before
returning back to the application.  So, skipping dirty pages that need to
hit the disk is just as big an error.  Since the FS can't know the context
of when writepage is called, it would be obligated to never return 1 when
the page has data that needs to hit disk. 

Is there an easier/better way to tell writepage callers to retry the page
write later?

-chris