Re: Prerelease kernel will not hotplug a USB host-controller when it is

[Andrew Morton]

Miles Lane wrote:
> 
> Hi Linus and Co.,
> 
> I am writing to let you know that in all test12-pre6+ kernels,
> I get a "Bad PCI invocation" error when hotplug attempts to
> handle the insertion of a USB host-controller into a Cardbus
> slot.

That message is coming from your hotplug scripts.

At approximately test12-o'clock the following change was made:

diff -u --recursive --new-file t12p7/linux/drivers/pci/pci.c linux/drivers/pci/pci.c
--- t12p7/linux/drivers/pci/pci.c       Thu Dec  7 15:56:26 2000
+++ linux/drivers/pci/pci.c     Thu Dec  7 12:21:51 2000
@@ -360,9 +360,9 @@
        if (!hotplug_path[0])
                return;
 
-       sprintf(class_id, "PCI_CLASS=%X", pdev->class);
-       sprintf(id, "PCI_ID=%X/%X", pdev->vendor, pdev->device);
-       sprintf(sub_id, "PCI_SUBSYS_ID=%X/%X", pdev->subsystem_vendor, pdev->subsystem_device);
+       sprintf(class_id, "PCI_CLASS=%04X", pdev->class);
+       sprintf(id, "PCI_ID=%04X:%04X", pdev->vendor, pdev->device);
+       sprintf(sub_id, "PCI_SUBSYS_ID=%04X:%04X", pdev->subsystem_vendor, pdev->subsystem_device);
        sprintf(bus_id, "PCI_SLOT_NAME=%s", pdev->slot_name);
 
        i = 0;

So I guess your PCI hotplug script hasn't caught up with this
change in the format of its arguments.

-