Re: [PATCH] PCI quirk for VIA ACPI device

Martin Mares (mj@suse.cz)
Wed, 26 Apr 2000 16:08:17 +0200


Hello!

> this patch (against 2.3.99-pre5) provides PCI quirk for VIA ACPI device (same as for Intel and ALI).
> Also modified PIIX4 and VIA support in /linux/arch/i386/kernel/acpi.c to use ioport
> base address from pci_dev structure.

> + pci_read_config_byte(dev, PCI_CLASS_REVISION, &rev);
> + rev = (rev & 0x10 ? 0x48 : 0x20);

This doesn't look well -- in case you select 0x20, you end up with single
resource present in both resource[4] and resource[7], resulting in immediate
resource collision.

Have a nice fortnight

-- 
Martin `MJ' Mares <mj@ucw.cz> <mj@suse.cz> http://atrey.karlin.mff.cuni.cz/~mj/
"29A, the hexadecimal of the Beast."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/