Re: [patch] drivers/net/3c59x.c

Jeff Garzik (jgarzik@mandrakesoft.com)
Tue, 25 Apr 2000 16:28:06 -0400

Andrew Morton wrote:
> > what is the purpose of vp->open? it seems redundant to netif_xxx bits,
> > and possibly racy
>
> It is to help the suspend() and resume() methods keep track of the
> open/close state of the interface.
>
> Yes, it may duplicate the use of IFF_UP.

sounds like you should be testing netif_running() instead, which is
always (and only) true between open() and close() time.

Maybe testing netif_device_present() might be more appropriate.

> > in vortex_remove_one, if dev==NULL you should probably call BUG()
>
> Added a printk(KERN_ERR...

BUG() not printk. You dereference dev->xxx immediately afterward, so an
oops will follow either way. Might as well have a controlled oops, and
one that will get optimized away when BUG() is changed for 2.4.0.

-- 
Jeff Garzik              | Nothing cures insomnia like the
Building 1024            | realization that it's time to get up.
MandrakeSoft, Inc.       |        -- random fortune


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/