Re: [PATCH] f_op->poll() without lock_kernel()

Andi Kleen (ak@muc.de)
Sun, 23 Apr 2000 13:00:49 +0200


On Sun, Apr 23, 2000 at 04:33:52AM +0200, Alexander Viro wrote:
> What I really don't like about the thing is the ->poll() interface. Here I
> _have_ some interest - it's used in NCPFS RPC. The main problem being: I
> would rather live without struct file for link to server. However, with
> sock->ops->poll() we have to keep one. Notice that

I don't see the gain behind the change. Please keep it as it is. I prefer
to think about TCP/UDP poll as a generic poll like all other poll functions,
not a specially-hacked networking poll. Flatter hierarchies are better here.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/