Re: [PATCH] pcnet32.c: MAC address may be in CSR registers

[Alan Cox]

> +int is_valid_ether_addr( char* address )
> +{
> +    int i,isvalid=0;
> +    for( i=0; i<6; i++)
> +	isvalid |= address[i]; 
> +    return isvalid && !(address[0]&1);
> +}

static and why not

static inline int is_valid_ea(u8 *addr)
{
	return memcmp(addr, "\000\000\000\000\000\000", 6) && !(addr[0]&1);
}

That all assembles to nice inline code 8)

Looks ok to me, Im picking holes now